Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Implement instance Data (#614) #652

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

clyring
Copy link
Member

@clyring clyring commented Feb 1, 2024

See here for an illustration of how this differs from the original patch.

@clyring
Copy link
Member Author

clyring commented Feb 1, 2024

Ugh. A @since marker on mkConstrTag would have saved me time here.

* Add functionality for toConstr

* Other instances fixed

* Move test

* test passes

* Add gshow tests

* Typo

* Add explicit string test

* instance Data: implement gunfold and dataTypeOf

* instance Data: fix tests

* Fix emulated builds

* Restore derived instance Data ShortByteString

* Add instance Generic ShortByteString

* Review suggestions

---------

Co-authored-by: Colton Clemmer <[email protected]>
(cherry picked from commit 1b9e6ec)
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clyring clyring added this to the 0.12.1.0 milestone Feb 1, 2024
@clyring clyring merged commit 3bded3c into haskell:bytestring-0.12 Feb 1, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants